Rewrite build script to use convention plugins#5416
Draft
modmuss50 wants to merge 23 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle has deprecated parent project method lookup for removal in Gradle 10. This is something that we were depending on for our project setup. This PR basically rewrites the whole build script to use convention plugins instead.
With this PR I have also enabled configuration cache, and moved the run configs over to using the Gradle tasks using the recent loom changes I have made.
This is not a perfect idomatic Gradle build script, I would love to enable features such as configure on demand and/or project isolation but thats a nightmare as far as I can tell. Please do suggest improvements where they are feasible. Where possible this should mirror the old build script as closly as possible.
Note: I have used AI tools to help with this, mostly for the large tedious refactors but this is certinally not vibe ported.
TODO
Future ideas